Fix some style issues - Githubissues

giabaio / survHE

Survival analysis in health economic evaluation Contains a suite of functions to systematise the workflow involving survival analysis in health economic evaluation. survHE can fit a large range of survival models using both a frequentist approach (by calling the R package flexsurv) and a Bayesian perspective.

https://gianluca.statistica.it/software/survhe/

41 stars 19 forks source link

Fix some style issues #5

Closed lemna closed 7 years ago

lemna commented 7 years ago

I'm reading trough the code to understand it, and tried to fix some style issues:

converted one cat to a message; this allows to suppress the output in RMarkdown
used <- as the assignment operator throughout
removed obsolete dropbox references

I feel that the code would be easier to read if each function were to have its own R file. Would you accept a PR for that?

Thanks, Peter

giabaio commented 7 years ago

Hi Peter, Thanks again for going through this with such a fine toothcomb! I've accepted your pull requests. As for having single files for each function, I don't disagree in principle --- it does make it neater in some sense; I sometimes find it easier to have only one file open with all the necessary functions... If you're doing it anyway, I'll consider it seriously and try and pull everything together --- is this fair?

BW Gianluca