search

giabaio / survHE

Survival analysis in health economic evaluation Contains a suite of functions to systematise the workflow involving survival analysis in health economic evaluation. survHE can fit a large range of survival models using both a frequentist approach (by calling the R package flexsurv) and a Bayesian perspective.
https://gianluca.statistica.it/software/survhe/
41 stars 19 forks source link

consistent data names for `km` and `make.surv` #52

Open n8thangreen opened 1 year ago

n8thangreen commented 1 year ago

km in fit.model output names time, mean, upper and lower 95% CI as

time, surv, lower, upper

make.surv output names these as

t, S, low, upp.

This makes applying a common function to both of these more difficult.

giabaio commented 1 year ago

Thanks. That's actually a good point. I suspect that I may have messed up slightly though and that the naming is propagated throughout the other utility functions (mainly plotting...). Have you checked this? It's probably a matter of grep to check when we're calling what? Or have you changed in your version and can push the changes to the main repo?

Thanks!

n8thangreen commented 1 year ago

I don't think these fields from make.surv are used very much internally. All I can find is one in psa.plot(). I can have a go at changing them - and try some tests?

giabaio commented 1 year ago

Ha --- even better then... That'd be cool if you are playing with it anyway?

Thanks!