search

giaever-online-iot / zwave-js-ui

Fully configurable Z-wave JS Control Panel and Z-Wave to MQTT Gateway
MIT License
11 stars 1 forks source link

fix: remove yarn, use npm #5

Closed robertsLando closed 12 months ago

robertsLando commented 12 months ago

@jmgiaever I have added some FIXME comment on places I'm not sure what to use

jmgiaever commented 12 months ago

Ty mate 🫶 Hah, I last night fixed stuff for 9.4.x 😆 I will try to transition for npm tomorrow. It's just burning around me atm. High season at work.

Why the change from yarn btw?

robertsLando commented 12 months ago

Hi Joachim 🫶

I saw you pushed some stuff recently, feel free to edit the missing pieces here if needed (or tell me what to do, I don't know anything about snap), I would drop the layout part entirely but I'm not sure so I let you check it when you have time, just wanted to help with the transition to make it less painfull as I know you are very busy in this period :)

Why the change from yarn btw?

Long story short is it turned me crazy with bugs on docker, the only way I found to make everything work was to use some mixed npm commands, after making it work I just decided to drop yarn entirely as there was no reason to have both, now image size has been reduced a lot and it also take only 7 minutes to build on all archs compared to 1h 🎉

You can find the full story behind this here: https://github.com/zwave-js/zwave-js-ui/issues/3430#issuecomment-1825526240

robertsLando commented 12 months ago

jq is no longer needed, it was to remove yarn dev deps. Dunno about yq it's not needed on my side 🤷🏼‍♂️

jmgiaever commented 12 months ago

I might use them to parse the settings file back and fourth, in the Bourne scripts. Can't recall. I think it's time to rework the project as so much has changed the past years.

jmgiaever commented 12 months ago

@robertsLando is npx needed?

And what about corepack?

robertsLando commented 12 months ago

Never used, dunno what is that for?