search

giaf / blasfeo

Basic linear algebra subroutines for embedded optimization
Other
321 stars 88 forks source link

improve header signature for blasfeo_pack_dvec, blasfeo_unpack_dvec #168

Closed FreyJo closed 1 year ago

FreyJo commented 1 year ago

This has caused some confusion before. The argument is a leading dimension, not an offset.

sandmaennchen commented 1 year ago

:heart: :heart:

giaf commented 1 year ago

Thanks for spotting this.

In case of vectors, that's actually an "increment", not a "leading dimension", see e.g. https://github.com/giaf/blasfeo/blob/master/include/blasfeo_d_blas_api.h#L97