search

giaf / blasfeo

Basic linear algebra subroutines for embedded optimization
Other
308 stars 84 forks source link

windows error: variable dummy being used without being initialized #70

Open dkouzoup opened 6 years ago

dkouzoup commented 6 years ago

The following routine segfaults on windows with the error written on the title:

blasfeo_dtrsm_lunn (note that the routine blasfeo_dtrsm_lunu is used just before without problems)

blasfeo is compiled with HIGH_PERFORMANCE and GENERIC (REFERENCE works fine)

dkouzoup commented 6 years ago

@tmmsartor can you have a look at this please?

dkouzoup commented 6 years ago

@giaf this fix should make his way into acados, is it "safe" to update to latest blasfeo after the fix or you'd rather not yet due to the latest experiments you're working on?

giaf commented 6 years ago

This https://github.com/giaf/blasfeo/commit/f786b0da61bcc365ed5fef5e9e72c01980a04751 should fix (I can't try it out, maybe make the changes locally to check it out)

I don't remember where the acados version stands, but recently a lot of stuff has been changed, and I don't know how much has been through unit tests again. @tmmsartor any idea?

tmmsartor commented 6 years ago

The latest changes are not tested yet.

I would avoid to keep the bleeding edge develop workflow and the stable branch together, at least until the tests are not fully automatized and thus ready to check every new commit.

I would suggest to track a specific branch or tag of BLASFEO in acados or similar upper level software, this order to minimize the chances of breaking those software and to be more agile to push eventual hot-fixes.

There are already acados-master or stable branches we can bump up and use these for acados and hpipm.

dkouzoup commented 6 years ago

Thanks for the fix @giaf, but it seems indeed a bit risky to update to the latest blasfeo-master before the latest changes are tested in some way. Ideally, we would keep the "stable" branch a bit more up-to-date or the "master" branch a bit more stable such that bug fixes can be cherry-picked in there. What do you think?