delete channel after socket is closed, fix #481

giampaolo / pyftpdlib

Extremely fast and scalable Python FTP server library

MIT License

1.65k stars 267 forks source link

delete channel after socket is closed, fix #481 #505

Closed yuantailing closed 3 years ago

yuantailing commented 5 years ago

self.create_socket is not guaranteed to be assigned to the same fd as self.bind_af_unspecified.

If they are different, there is a closed socket in Select._r and the bug occurs.

coveralls commented 5 years ago

Coverage remained the same at ?% when pulling 6237d8ee3a64ab76fa6fd3a9bfa66b43c28c4669 on yuantailing:patch-1 into 3e9af286e1d0e9ccf4f9e2306af44635a3e3faae on giampaolo:master.