search

giampaolo / pyftpdlib

Extremely fast and scalable Python FTP server library
MIT License
1.66k stars 266 forks source link

Add Python versions to GHA Windows #587

Closed gliptak closed 1 year ago

gliptak commented 1 year ago

Signed-off-by: Gábor Lipták gliptak@gmail.com

Win 3.7 fails with

FAIL: pyftpdlib.test.test_filesystems.TestAbstractedFS.test_validpath_external_symlink
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\site-packages\pyftpdlib-1.5.8-py3.7.egg\pyftpdlib\test\test_filesystems.py", line 195, in test_validpath_external_symlink
    self.assertFalse(fs.validpath(u(testfn)))
AssertionError: True is not false
giampaolo commented 1 year ago

I think there's no need to test so many python versions on Windows (it slows down CI run). 2.7 and one (any) recent 3.X is enough. Same goes for other platforms except Linux.