giampaolo / pyftpdlib

Extremely fast and scalable Python FTP server library
MIT License
1.65k stars 265 forks source link

Always return 200 for OPTS UTF8 or OPTS UTF-8 ON #596

Open amirzak opened 1 year ago

amirzak commented 1 year ago

Fix #266 and #531. Took inspiration from vsftpd for 200 reply message - https://github.com/dagwieers/vsftpd/blob/ce2fa4288b92683f832c3b5179d5cb2a77d0750e/opts.c#L20

Let me know if additional changes are needed in order to merge it.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (4165a47) 69.81% compared to head (f3abf96) 69.72%. Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #596 +/- ## ========================================== - Coverage 69.81% 69.72% -0.10% ========================================== Files 9 9 Lines 3614 3623 +9 ========================================== + Hits 2523 2526 +3 - Misses 1091 1097 +6 ``` | [Files](https://app.codecov.io/gh/giampaolo/pyftpdlib/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola) | Coverage Δ | | |---|---|---| | [pyftpdlib/handlers.py](https://app.codecov.io/gh/giampaolo/pyftpdlib/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola#diff-cHlmdHBkbGliL2hhbmRsZXJzLnB5) | `70.37% <100.00%> (-0.13%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/giampaolo/pyftpdlib/pull/596/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.