codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 66.66% and project coverage change: +0.06 :tada:
Comparison is base (
4165a47) 69.81% compared to head (76857d6) 69.87%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #600 +/- ## ========================================== + Coverage 69.81% 69.87% +0.06% ========================================== Files 9 9 Lines 3614 3612 -2 ========================================== + Hits 2523 2524 +1 + Misses 1091 1088 -3 ``` | [Impacted Files](https://codecov.io/gh/giampaolo/pyftpdlib/pull/600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola) | Coverage Δ | | |---|---|---| | [pyftpdlib/authorizers.py](https://codecov.io/gh/giampaolo/pyftpdlib/pull/600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola#diff-cHlmdHBkbGliL2F1dGhvcml6ZXJzLnB5) | `46.62% <ø> (ø)` | | | [pyftpdlib/log.py](https://codecov.io/gh/giampaolo/pyftpdlib/pull/600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola#diff-cHlmdHBkbGliL2xvZy5weQ==) | `36.36% <0.00%> (ø)` | | | [pyftpdlib/handlers.py](https://codecov.io/gh/giampaolo/pyftpdlib/pull/600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola#diff-cHlmdHBkbGliL2hhbmRsZXJzLnB5) | `70.60% <83.33%> (+0.10%)` | :arrow_up: | | [pyftpdlib/\_\_main\_\_.py](https://codecov.io/gh/giampaolo/pyftpdlib/pull/600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola#diff-cHlmdHBkbGliL19fbWFpbl9fLnB5) | `83.07% <100.00%> (ø)` | | | [pyftpdlib/filesystems.py](https://codecov.io/gh/giampaolo/pyftpdlib/pull/600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola#diff-cHlmdHBkbGliL2ZpbGVzeXN0ZW1zLnB5) | `81.38% <100.00%> (-0.12%)` | :arrow_down: | | [pyftpdlib/ioloop.py](https://codecov.io/gh/giampaolo/pyftpdlib/pull/600?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola#diff-cHlmdHBkbGliL2lvbG9vcC5weQ==) | `90.01% <100.00%> (+0.18%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Giampaolo+Rodola):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Adds a new
make pylinttarget to run pylint against the code base. I don't want to make pylint mandatory. Don't want to run it on commit/push and reject commits, since pylint is waaaay too strict. This is just meant to be used manually from time to time. Nevertheless, running it against the whole code base for the first time revealed many places which were worth being refactored.