gianarb / orbiter

Orbiter is an opensource docker swarm autoscaler
Apache License 2.0
505 stars 54 forks source link

scale up post cmd failure #34

Closed lhenry7 closed 7 years ago

lhenry7 commented 7 years ago

I started orbiter with the attached orbiter-stack.yml file, then a service with orbiter flags. Initial scale up and scale down worked, but after scaling down to 1, scale up gave error about not being able to scale down. Used "curl -v -X POST localhost:8081/handle/autoswarm/stage-investor-relations_app/up" for all tests. Log file also attached.

orbiter-scale-error.zip

lhenry7 commented 7 years ago

Just wanted to add this as well in case it helps:

[root@ip-10-227-81-34 ~]# curl -v -X GET http://localhost:8081/v1/orbiter/autoscaler

gianarb commented 7 years ago

Hello @lhenry7 thanks for your feedback. I tried reproducing this issue without success but in the meantime, I fixed an error message and I also change a bit the logic behind that check.

https://github.com/gianarb/orbiter/pull/35

The code is merged. Can you update orbiter and give it a try? Let me know! I will keep trying.

gianarb commented 7 years ago

All done @lhenry7 ! It works! I was able to reproduce the bug and it is fixed. Update orbiter and let me know!

You opened a very good PR with a lot of information! Super

Please can you close the PR if my fix is working for you too?

lhenry7 commented 7 years ago

Yes, works now. Thanks