search

gianarb / orbiter

Orbiter is an opensource docker swarm autoscaler
Apache License 2.0
501 stars 54 forks source link

Bug/41 #42

Closed mbovo closed 7 years ago

mbovo commented 7 years ago

Solve the issue #41 @fntlnz as you reported, i've updated using the workaround suggested moby/moby/issues/33989 This break vendoring at this time. Running again dep ensure will replace the docker/docker lib with version 17.5.0-ce-rc3

fntlnz commented 7 years ago

@mbovo worth using v17.06.1-ce ?

@gianarb reviewing this PR evidences that we are missing a lot of testing !

fntlnz commented 7 years ago

@mbovo we needed to address this so @gianarb created a PR on top of your work keeping your commits. https://github.com/gianarb/orbiter/pull/46

gianarb commented 7 years ago

thanks @mbovo !https://github.com/gianarb/orbiter/pull/46

mbovo commented 7 years ago

No problem, was afk for a while in the last days

gianarb commented 7 years ago

Sorry, I was happy to have it merged asap! :heart: