Open Zero3 opened 9 years ago
giancosta86
commented
9 years ago Alas, I still can't reproduce this issue... what NetBeans bundle are you using? :) Are you still facing the problem? Have you installed additional plugins which might interfere?
Zero3
commented
9 years ago I can reproduce by simply enabling the filter and clicking OK. The red warning icon then immediately appears at the bottom right of the screen in the status line (same place where update notifications / restart notifications pop up).
I'm quite sure I downloaded the Java SE bundle back when I installed Netbeans.
I got 41 "plugins" installed according to the plugin manager in Netbeans. Most of these are from the bundle, but I installed a few through the "Available Plugins" tab. I have no idea what to look for with regards to interference. Let me know if there is anything you would like me to try.
The Netbeans about page shows the following. Maybe it is of any help:
Product Version: NetBeans IDE 8.0.2 (Build 201411181905)
Updates: NetBeans IDE is updated to version NetBeans 8.0.2 Patch 2
Java: 1.8.0_45; Java HotSpot(TM) 64-Bit Server VM 25.45-b02
Runtime: Java(TM) SE Runtime Environment 1.8.0_45-b15
System: Windows 7 version 6.1 running on amd64; Cp1252; da_DK (nb)In order to reproduce the issue, I have just installed the latest NetBeans 8.0.2 (201411181905) for Java SE on a clean virtual machine with JDK 8, and:
As a consequence, I'd say there's some sort of classpath interference with other style-related plugins, probably with one referencing PMD...
Disabling a few checker plugins should make it easy to find out which of them caused the interference.
Zero3
commented
9 years ago Thanks for looking into this. I will try disabling plugins in an attempt to track down a conflict. I will get back to you after trying.
giancosta86
commented
9 years ago It seems that fixing this bug would require not to exclude Saxon and Xerces from EasyPmd's Maven dependencies, but that would cause bug #7, which is far worse. Therefore, I'll have to exclude them again, at least for now.
Zero3
commented
8 years ago For your information, I tracked the exception to the AvoidLiteralsInIfCondition rule from PMD's controversial.xml ruleset:
<rule name="AvoidLiteralsInIfCondition"
language="java" since="4.2.6"
message="Avoid using Literals in Conditional Statements"
class="net.sourceforge.pmd.lang.rule.XPathRule"
externalInfoUrl="${pmd.website.baseurl}/rules/java/controversial.html#AvoidLiteralsInIfCondition">
<description>
Avoid using hard-coded literals in conditional statements. By declaring them as static variables
or private members with descriptive names maintainability is enhanced. By default, the literals "-1" and "0" are ignored.
More exceptions can be defined with the property "ignoreMagicNumbers".
</description>
<priority>3</priority>
<properties>
<property name="ignoreMagicNumbers" description="Comma-separated list of magic numbers, that should be ignored"
type="String" value="-1,0"/>
<property name="xpath">
<value>
<![CDATA[
//IfStatement/Expression/*/PrimaryExpression/PrimaryPrefix/Literal
[not(NullLiteral)]
[not(BooleanLiteral)]
[empty(index-of(tokenize($ignoreMagicNumbers, ','), @Image))]
]]>
</value>
</property>
<property name="version" value="2.0"/>
</properties>
<example>
<![CDATA[
private static final int MAX_NUMBER_OF_REQUESTS = 10;
public void checkRequests() {
if (i == 10) { // magic number, buried in a method
doSomething();
}
if (i == MAX_NUMBER_OF_REQUESTS) { // preferred approach
doSomething();
}
if (aString.indexOf('.') != -1) {} // magic number -1, by default ignored
if (aString.indexOf('.') >= 0) { } // alternative approach
if (aDouble > 0.0) {} // magic number 0.0
if (aDouble >= Double.MIN_VALUE) {} // preferred approach
}
]]>
</example>
</rule>Edit: The same is true for OneDeclarationPerLine as noted in https://github.com/acanda/eclipse-pmd/issues/17.
rkraneis
commented
6 years ago This still happens with current EasyPMD on current NetBeans 8 dev :-/
With Netbeans 8.0.2 and JDK 8, I get the following exception (caught by Netbeans) when the
controversialdefault filter is enabled: