No need to expose port on same docker network and version is obsolete

giandonatoinverso / PHP-Dynamic-Qr-code

PHP Dynamic Qr code is a script that allows the generation and saving of dynamic and static QR codes

MIT License

243 stars 73 forks source link

Closed lekpamartin closed 1 month ago

lekpamartin commented 1 month ago

Two fix in the PR:

version is obsolete
For security expose only necessary ports. No need to expose DB port on same docker network
Thx

giandonatoinverso commented 1 month ago

Port exposure is useful for debugging purposes (in. phpmyadmin). The end user can decide whether to delete it.