search

giandonatoinverso / PHP-Dynamic-Qr-code

PHP Dynamic Qr code is a script that allows the generation and saving of dynamic and static QR codes
MIT License
241 stars 73 forks source link

Embed Logo Inside QRCode #38

Open 0xRenegade opened 1 year ago

0xRenegade commented 1 year ago

Referencing issue which had a list of ideas, and since it was closed, sorting those into their own issues. (issue #27):

Basically the title, add option to embed logo inside a given qrcode. Food for thought: Would this still work on dynamic qrcodes?

giandonatoinverso commented 1 year ago

It could work but this project was born as a manager of dynamic qr code and should not deal with the actual generation.

In fact the qrcodes are generated by an external provider which, in theory, offers the possibility to insert a logo inside the qr code. However, it is known that adding images inside qrcode reduces its readability by the various readers in circulation. To customize the qrcode it would be better to work on the color or style of the same rather than trying to "embellish" it with graphic elements (eg logo images)

0xRenegade commented 1 year ago

It could work but this project was born as a manager of dynamic qr code and should not deal with the actual generation.

In fact the qrcodes are generated by an external provider which, in theory, offers the possibility to insert a logo inside the qr code. However, it is known that adding images inside qrcode reduces its readability by the various readers in circulation. To customize the qrcode it would be better to work on the color or style of the same rather than trying to "embellish" it with graphic elements (eg logo images)

Good points. Would it be better to make some kind of border/frame to go around it like a picture that has customized styling and/or images outside of the qrcode, such as a logo?

giandonatoinverso commented 1 year ago

I like. This is a good idea that is better suited to the concept of qr code manager and that frees customization from generation.

It would be necessary to intervene at the level of creation of the qr code, creating a new image based on the qr code generated by the provider and on the customization options previously chosen by the user.

0xRenegade commented 1 year ago

should we have the qrcode column like it is now, and add a new one for the new feature so that if they go to update it, it only changes the custom version, leaving the base in tact for use in updating in the future?

EDIT: This could also be a json encoded field for multiple custom versions?

giandonatoinverso commented 1 year ago

Yes, the imports must be incremental, i.e. the new qr codes not existing in the db must be added and those already existing but modified must be replaced

0xRenegade commented 1 year ago

This could also be a json encoded field for multiple custom versions, leaving it as a dynamic iteration of the custom versions they've created. or foreign key to new table (i like json for this one)

giandonatoinverso commented 1 year ago

Managing different versions of the same qrcode could be complex and not bring a concrete advantage to the user. It would also burden management and general usability.

It would be better to have, at least initially, a simple incremental qr code import system

RubenDebusscher commented 3 months ago

I was looking for a way to manage the QR's I will need, and to have some statistics about them, together with a lot of customisations. And I found this topic because I would like the option to add an image when needed. I started to look further, and I found this project EasyQRCodeJS. Maybe this might be a way to have a customisable self hosted generator inside the manager?

giandonatoinverso commented 3 months ago

Yes it could be a great generator. I invite you to contribute to the project