Submission for assignment 5. - Githubissues

giangbimin / df-frontend-2023

frontend-training

https://df-frontend-2023-kappa.vercel.app

1 stars 0 forks source link

Submission for assignment 5. #5

Open giangbimin opened 1 year ago

giangbimin commented 1 year ago

Assignment - 1 Link Demo: Link demo

tienan92it commented 1 year ago

Hello @giangbimin , great work! Below is some feedback for your assignment.

Requirements

[x] All core functionalities present
[x] Edit form
[x] Login page
[x] Forms built by react-hook-form
[x] Validation by zod
[x] Bonus: Password Strengh Meter

Final result: 🔥 passed 100% of requirements

Feedback

Usually, it doesn't need to validate strength of password in Login Form to avoid revealing system rules. https://github.com/giangbimin/df-frontend-2023/blob/70d21d131c26a84e1fe19fd57ea6388adab163a7/assignment-5/app/_types/schema/LoginSchema.tsx#L5-L24