gianlucadelgobbo / AVnode.net

3 stars 4 forks source link

ControlPanel: Public Data #130

Closed gianlucadelgobbo closed 5 years ago

gianlucadelgobbo commented 6 years ago

Stagename:

Profile url:

About:

SOCIALS:

ADDRESS:

GENERAL

danielesalvatore commented 6 years ago

Every section: Validation parameters where they are coming from? How to manage it?

As any other section, the validation function and parameters are defined in the validate.js file you can find in the folder correspondent to the section you refer to (e.g. for the Profile > Public section, go to src/app/redux/components/profile/public/validate.js.

Every section: Serverside error are ignored

I just fixed for all the Profile section the rendering of the server side errors: given that for this section we don't use a specific id to load the info of the authenticated user, i switched the getErrorMessage() methods to be getDefaultModelErrorMessage(). This is because the first method expected an id to select the correspondent model, the second on get the error message of the first loaded model.

Every section: Error messages where they are coming from? Are they multilang...

As any other label in the UI they are multi-language and they have to be handled as any other multi-lang string in the application. (Define the translations, extract the messages, etc.). In the validate.js function is where a specific error message is set for a specific validation function.

Stagename > check on input? We validate that its length must be between 3 and 50 chars (this imply that the parameter is required).

Profile url > check on input? Fixed: We now validate that its length must be between 3 and 50 chars (this imply that the parameter is required).

*About > Why ?** To show that the specific tab has a validation error. This is because if a tab has a validation error, its error message is not shown unless the tab is selected. Having this, the user can see that the tab has "something to wrong". Should we keep it?

About > max length? Currently, every text can be max 5000 chars. The value can be changed within the validate.js file.

Address > on remove strange message

What do you mean?

screen shot 2018-09-22 at 10 52 27

Address > search selection not visible

What do you mean? the input is the search itself

screen shot 2018-09-22 at 10 53 40

Generals > all the issue I don't understand what you mean

gianlucadelgobbo commented 6 years ago

Every section: Validation parameters where they are coming from? How to manage it?

Is better that we use the config.json where there is everything? src/app/redux/components/profile/public/validate.js can load value from that file?

GENERAL

if there is a client side error on save nothing happen (no target, no messages)

Success prompt can disappear after a while?