gianlucagiacometti / Roundcube-Forward

RoundCube plugin to set forward addresses in PostfixAdmin database
GNU General Public License v2.0
7 stars 10 forks source link

call PostfixAdmin code instead of using raw database queries #6

Open cboltz opened 8 years ago

cboltz commented 8 years ago

roundcube-forward works directly on the database level. This might work, but it might also break if something in the PostfixAdmin database layout changes.

It would be a good idea to call the PostfixAdmin code directly. This would ensure you don't suffer or break something if the database layout changes. It would also give you all the features implemented in the *Handler classes that are available in PostfixAdmin 3.0 (still labeled beta, but the final release will be available soon).

Possible options:

The same recommendation applies to roundcube-aliases. I won't open a separate issue there to avoid duplication, but it should also be changed in the way described above.

If needed, I can help you with those things ;-) - just respond here or come to #postfixadmin on Freenode (I'm typically online on CET/CEST late evening ;-)

.

Christian (from PostfixAdmin)

PS: Dear github, mail copy to @ccboltz please ;-)

gianlucagiacometti commented 8 years ago

Hi Christian, sorry far the delay. I must thank you for your suggestions. I agree 100% and I think we can cooperate to improve the plugings. I think that directly including the PostfixAdmin AliasHandler class would be the better solution. Usually I work on them every now and then when I do my updates, we just have to find a free moment for both.