search

giannello / addon-warema-bridge

20 stars 23 forks source link

Remove leading zeros of serial numbers from topics / add tilt to model 25 #6

Closed ol-iver closed 2 years ago

ol-iver commented 3 years ago

@giannello, thanks for the library I changed two things to make it work with my blinds. Maybe you are interested in those changes too

  1. The serial number of my blinds include leading zeros. The data structures of the callback function do not include those leading zeros, so the state of my blinds was not refreshed. That's why I removed the leading zeros when creating the mqtt topics device registration.
  2. My blinds report model 25 but support the tilt command, so I added it here too.
giannello commented 3 years ago

hi @ol-iver, thank you for the PR!

I have tested it, and while the trimming of the serial numbers works fine, I'm afraid that adding support for tilt like this will cause confusion: image

As you can see, tilt is added also to shades that don't support it.

Would you mind sharing more info about your Warema setup (models/type of shades), and maybe try to restrict adding the tilt support only for shades that actually support it?

ol-iver commented 3 years ago

Unfortunately, the library does not tell me much about my shades typeStr listed here is undefined for my blinds. type is 25 and the serial number of course. It didn't find anything useful in Warema WMS studio pro neither. All I see is that the hardware supports tilding and it works when I add it to the library.

giannello commented 2 years ago

@ol-iver haven't forgot about this.

I think that: