search

gianni-rosato / svt-av1-psy

The Scalable Video Technology for AV1 (SVT-AV1 Encoder and Decoder) with perceptual enhancements for psychovisually optimal AV1 encoding
https://svt-av1-psy.com
BSD 3-Clause Clear License
261 stars 20 forks source link

[BUG] --progress 3 is showing ASCII escape codes as instead of colors on Windows Builds #46

Closed agressiv closed 6 months ago

agressiv commented 6 months ago

Overview --progress 3 is showing ASCII escape codes as instead of colors on Windows Builds

Branch In which branch does the issue appear to be occurring?

Reproduction Steps to reproduce the behavior:

  1. Download the 2.0.0 A Windows binary from this github repo.
  2. Run an encode with --progress 3 on Windows

Expected behavior Colors show for various encoding methods without ASCII escape characters.

Terminal Output Encoding: ←[33m 49 Frames←[0m @ ←[32m29.94←[0m fps | ←[35m209.13 kb/s←[0m | Time: ←[36m0:00:02←[0m | Size: ←[31m0.24 MB←[0m

Platform (please complete the following information):

Version String (please complete the following information):

Additional context / Relevant Files N/A. Pretty straightforward. Purely cosmetic bug. I've tried at least 5-6 different console fonts, in cmd and powershell. Linux build seems to be fine.

gianni-rosato commented 6 months ago

Hi, please fill out the bug report issue template in its entirety so we can better reproduce your issue in order to understand what's going on.

agressiv commented 6 months ago

i've retrofitted my top comment.

gianni-rosato commented 6 months ago

Thanks so much for the extra info. I've been able to confirm that some users are experiencing the same issues on Windows 10, so I will try to reproduce this on W11 & get back to you with next steps or a fix. Thanks for your patience!

agressiv commented 6 months ago

tbh don't really need the color. It's just great getting the extra stats that vanilla SVT doesn't have!

gianni-rosato commented 6 months ago

This has now been fixed in the testing branch via 113d9ee82b354a8f25e59078cbcebf9a107891fe which just disables ANSI escape codes for Windows. This will be live on master as soon as testing is merged. Thanks for your patience!