search

giannifranchi / LP_BNN

This repository contains an official implementation of LPBNN.
39 stars 5 forks source link

LPBNN_layers bug? #3

Open jadie1 opened 1 year ago

jadie1 commented 1 year ago

Hello, thanks for providing your code.

I have a question, LPBNN_layers line 75 is: embedded_mean, embedded_logvar=self.encoder_fcmean(embedded),self.encoder_fcmean(embedded) Should this not be: embedded_mean, embedded_logvar=self.encoder_fcmean(embedded),self.encoder_fcvar(embedded) As it is, it appears to be enforcing that the mean and logvar are the same. This bug is present in every layer defined in LPBNN_layers.

Additionally, I was wondering why VAE embedding is applied only for alpha and not for gamma. Is there a benefit to only defining alpha as Bayesian? Was this the case for the results reported in your paper?

giannifranchi commented 1 year ago

Thanks for your comment. We will correct that mistake and retrain for the end of this week.

Best,