search

giannimonaco / flowAI

3 stars 6 forks source link

Wrong test? #20

Closed SamGG closed 5 months ago

SamGG commented 5 months ago

I think the test does not match the message. https://github.com/giannimonaco/flowAI/blob/2af15bdabc0416e9e63882cea6f6fd16557e0872/R/anomaly-detection.R#L65-L67

giannimonaco commented 5 months ago

Thank you for spotting this. I appreciate it! I fixed the if statement.

On Wed, Mar 27, 2024 at 6:05 PM Samuel Granjeaud @.***> wrote:

I think the test does not match the message.

https://github.com/giannimonaco/flowAI/blob/2af15bdabc0416e9e63882cea6f6fd16557e0872/R/anomaly-detection.R#L65-L67

— Reply to this email directly, view it on GitHub https://github.com/giannimonaco/flowAI/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2UTEAG4ZOGL6LVSW2J5P3Y2MYCRAVCNFSM6AAAAABFLWYHIWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTCOJYGM4DGMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SamGG commented 5 months ago

Thanks for your feedback. I think that even alpha = 0.1 is too permissive because it is equivalent to stating 0.1 outlier among N random numbers from a gaussian distribution.