giannimonaco / flowAI

3 stars 6 forks source link

Min and Max Range formatted as characters instead of double #5

Closed timmocking closed 2 years ago

timmocking commented 2 years ago

A small suggestion: flowAI converts the Min and Max range as defined in the .FCS parameters to characters. This is normally not an issue, as saving the .FCS re-converts these to doubles. However, if you run an additional anomaly detection algorithm after running flowAI, the output is erroneous because of this.

library(flowAI)
library(flowCore)

ff <- read.FCS(FILE)
ff <- flow_auto_qc(ff, output=2)

meta <- flowWorkspace::pData(flowCore::parameters(ff))
typeof(meta['FSC-A', 'minRange'])
giannimonaco commented 2 years ago

Hi! Thank you for reporting this! You are right, the Min and Max range values were converted to characters for output=2. I just fixed it. Just use the github version if you need the fixed version soon.

On Tue, 30 Nov 2021 at 12:57, Tim Mocking @.***> wrote:

A small suggestion: flowAI converts the Min and Max range as defined in the .FCS parameters to characters. This is normally not an issue, as saving the .FCS re-converts these to doubles. However, if you run an additional anomaly detection algorithm after running flowAI, the output is erroneous because of this.

library(flowAI) library(flowCore)

ff <- read.FCS(FILE) ff <- flow_auto_qc(ff, output=2)

meta <- flowWorkspace::pData(flowCore::parameters(ff)) typeof(meta['FSC-A', 'minRange'])

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/giannimonaco/flowAI/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2UTEEWBB32COMEDT2RJ5LUOS33BANCNFSM5JBTPEKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.