giannimonaco / flowAI

3 stars 6 forks source link

flow_auto_qc() creates QC file with wrong file name #8

Closed phauchamps closed 2 years ago

phauchamps commented 2 years ago

Hi dear flowAI team,

I noticed that when I launch flow_auto_qc() with 1.24 version of flowAI, and ouput parameter = 1, the QC fcs file that is generated in the 'resultsQC' directory is wrongly named after 'V1_QC' instead of 'myfilename_QC'.

Does this issue sound familiar to you ?

Thanks,

Philippe

giannimonaco commented 2 years ago

Hi Philippe,

Thank you. Yes, I know the issue. The version 1.25.2 that you find on github (or the bioconductor developmental branch) already includes the fix.

Best wishes, Gianni

On Fri, 24 Dec 2021 at 09:30, Philippe Hauchamps @.***> wrote:

Hi dear flowAI team,

I noticed that when I launch flow_auto_qc() with 1.24 version of flowAI, and ouput parameter = 1, the QC fcs file that is generated in the 'resultsQC' directory is wrongly named after 'V1_QC' instead of 'myfilename_QC'.

Does this issue sound familiar to you ?

Thanks,

Philippe

— Reply to this email directly, view it on GitHub https://github.com/giannimonaco/flowAI/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2UTEHT7EFCIFBVDF4GNBDUSQVQVANCNFSM5KWIG4EQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

phauchamps commented 2 years ago

Thank you Gianni,

Looking into the closed issues first would have saved us both some time, sorry for that ;-)

Best wishes, Philippe.

giannimonaco commented 2 years ago

No problems! :) Cheers, Gianni