jefforkin
commented
8 years ago Dave, question for clarification:
Do you start client 1 (customer) and immediately start client 2 (waitress)? Or, do you wait for the customer to start the game (past the cue card), and then start client 2?
Do you see different behavior in both of these cases, or do they both exhibit the bug?
I just tried both of these possibilities, with the code you sent me for sit changes, and actually did not see the bug in either case. So, it definitely seems to be a race condition, exacerbated by your hardware and/or your geographic distance from the IRC server.
I can poke around a bit more and try to force the bug to occur, and alternatively I can look for ways to fortify the code to try to eliminate the issue, even if I cant repro it -- like possibly adding some kind of acknowledgement when a player joins a room (or some related event occurs), so that perhaps the roombot could resend critical messages.
dwenger01
1) A little background - I have some local code changes that support reading in spawn pose data from the project file (dave_rest_spawn in this case), and it also reorders the roles so the customer shows up first. So when the customer spawns in the code detects that he should be sitting in chair.01. This causes him to try to sit, and even though I have him spawning in very close to the chair he thinks he needs to perform a GOTO operation. Everything works correctly in "single player" - i.e. no other players join.
2) In the case when the 2nd player joins, everything in the first player's world is deleted. All player one's scene objects go away, the loading screen is displayed again, and then the cue card finally comes up with the timer reset after the scene reloads. The 2nd player (waitress) has loaded up by this point and its cue card is timing down.
3) Eventually the first player rejoins, but at this point he is not visible to the waitress. i.e. Player 1 (customer) can see Player 2 (waitress), but not vice versa.
I've set breakpoints in the room_bot code and each player is definitely joining the room as I'd expect. They also receive their OnMsgNewPlayer() messages in the Character class - however it seems that the customer (who I have the debugger attached to) is not told about NewPlayer for the waitress. He gets the chef and and bartender, but no waitress NewPlayer() message. It just seems like there is a race condition where Player 1 is not available to receive the waitress NewPlayer() since he has not yet loaded up himself when she tells him she's joined.
After the first or 2nd game play when the scenario ends and new one begins both players seem to get all the messages and see each other correctly. The issue just seems exacerbated in the initial load case.
I'm still a bit confused as to why Player 1 completely blows away his scene and resets when Player 2 initially joins, but perhaps this is the easiest way to reset player 1's scene state. I would think he would just hang out indefinitely without the other player until Player 2 joins, then just reset the initial world state (from cache perhaps) and allow Player 2 to join his scene.
The other thing I'm slightly confused about is that the Character class is the class that handles the OnMsgNewPlayer() message. I think in the case where we're not seeing the waitress join Player 1's game it's because there is no Character instance available to handle the message. Is there any way that the message could be handled by a different class? Or maybe I'm misunderstanding what's happening here, but it looks like the Customer Character instance is the one handling when the chef and bartender enter the scene, but when the customer is not there when the waitress joins, we are not able to add the waitress to the scene.