giantotter / giantotter_public

2 stars 0 forks source link

Relax CriticExtendedEventTypeChange #821

Open jefforkin opened 7 years ago

jefforkin commented 7 years ago

This critic prevents changing an event's type if it leads to a sequence at level 1 that doesn't match any of the packed logs.

Since we now have level 1 event aliasing, we should allow changing the level 0 event's type, as long as the level 1 event does not change.

Without this, we see some issues, like Olivia unable to respond to "I have some feedback for you" if said after asking "how do you think it went?"