search

giantpinkrobots / varia

Download manager based on aria2
https://giantpinkrobots.github.io/varia/
Mozilla Public License 2.0
298 stars 30 forks source link

bugs: Downloads added with browser extension sometimes not registered + Downloading stuff from Firefox displays random file name #71

Closed fiftydinar closed 2 weeks ago

fiftydinar commented 6 months ago

With initial Firefox extension support, I see this behavior.

giantpinkrobots commented 6 months ago

When a download is first added it parses the URL for a file name, but after a second it should update with the actual file name. Can you send a screenshot?

fiftydinar commented 6 months ago

When a download is first added it parses the URL for a file name, but after a second it should update with the actual file name. Can you send a screenshot?

Just when I wanted to test this again, so I can send a screenshot, it works correctly. But on next launch, it doesn't want to download anything. It just says Download Canceled in Firefox.

So I have a mixed experience.

giantpinkrobots commented 6 months ago

Strange. Did you try to download the same thing from the same link and it didn't register? Or some other file?

fiftydinar commented 6 months ago

Strange. Did you try to download the same thing from the same link and it didn't register? Or some other file?

I tried same links 1st, then different ones.

giantpinkrobots commented 6 months ago

Are you using the Flatpak version?

fiftydinar commented 6 months ago

Are you using the Flatpak version?

Yes. Latest v2024.2.29-2.

Fedora Silverblue 39.

giantpinkrobots commented 6 months ago

I changed something in the code that may have been causing that. Can you install this flatpak file and test? https://drive.proton.me/urls/QVBRMZCQ18#Gylufq3sPv62

fiftydinar commented 6 months ago

I changed something in the code that may have been causing that. Can you install this flatpak file and test? https://drive.proton.me/urls/QVBRMZCQ18#Gylufq3sPv62

Hmm, I still get some mixed results.

I deleted data before installing this version.

giantpinkrobots commented 6 months ago

Downloads are still not being registered? If you can write what you do and what happens more in detail I can reproduce it.

fiftydinar commented 6 months ago

I catched the random file-name bug.

You just have to download the file from same link a lot of times, while quitting & re-opening the app multiple times too.

Link: https://github.com/JacobDev1/xl-converter/releases/download/v0.9.7/xl-converter-linux-0.9.7-x86_64.AppImage

Screenshot from 2024-03-05 15-22-16

Raul1198 commented 5 months ago

+1 i too get this download not being sometimes not registered and random file name show in varia but correct file name shown in the file manger Random Name - Screencast from 2024-04-14 17-03-59.webm using varia version v2024.03.20 flatpak on Fedora Worksation 39 and in Firefox ask where to save is unticked

giantpinkrobots commented 4 months ago

I think the thread that is created when a download is added might be acting before aria2 is able to assign the download a file name? I'm honestly not sure, because I can't consistently reproduce this, but to be sure I've moved the function that sets the file name in Varia into the main thread loop. The function now continuously checks if the filename has been changed, and if so, updates it in the GUI.

Now I don't think this is the best way to fix this issue, but I will release it in the next version. Hopefully it will fix the issue then.

Let's keep this issue open for a bit. If you see the same problem after the update, please report it here. If there are no reports for a good while, I will then close the issue.

giantpinkrobots commented 4 months ago

The fix has been released with v2024.5.7. I will wait a week until I close this issue.