search

giantswarm / azure-operator

Manages Kubernetes clusters running in in a Giant Swarm installation on Microsoft Azure
https://giantswarm.io/
Apache License 2.0
30 stars 7 forks source link

Backport drain nodes feature #1559

Closed whites11 closed 2 years ago

whites11 commented 2 years ago

This is a cherry pick of https://github.com/giantswarm/azure-operator/pull/1555 into the 5.8 release branch for platform release 15.1.3

whites11 commented 2 years ago

Locally run cncf tests are green. e2e tests are still failing but it's a platform problem

fiunchinho commented 2 years ago

did you try running the e2e tests locally with go test?

whites11 commented 2 years ago

did you try running the e2e tests locally with go test?

I did but some of them were failing like they did with 16.0.2. Maybe it's about how I create the cluster

whites11 commented 2 years ago

running tests locally fails as well. The problem seems to be with API versions. For example the autoscaler_test.go tries to find a MachinePool CR (capi v1alpha4) but can't find any. I think this is a consequence of the adaptations to make tests to work on CAPZ clusters.

whites11 commented 2 years ago

tests are green locally