giantswarm / docs

The Giant Swarm documentation site
http://docs.giantswarm.io
Apache License 2.0
4 stars 8 forks source link

Document logging architecture #2170

Closed QuentinBisson closed 7 months ago

QuentinBisson commented 7 months ago

What this PR does / why we need it

Closes https://github.com/giantswarm/giantswarm/issues/29776#issue-2122988280

This documentation explains what our logging architecture is

Things to check/remember before submitting

QuentinBisson commented 7 months ago

Thanks for the review @stone-z :) I always love a native speaker's nitpicking :)

marians commented 7 months ago

Loki should be spelled Loki (uppercase L) everywhere.

QuentinBisson commented 7 months ago

Thanks @marians, it's fixed

marians commented 7 months ago

I didn't expect new content to be added to the /vintage folder. Slightly confused now.

QuentinBisson commented 7 months ago

@marians I added it under vintage because to me, the new structure is not complete. There are no entries there yet and we needed that documentation finished to close our logging epic

pipo02mix commented 7 months ago

I am working to have a second-level hierarchy done to start moving/adapting content. PRs are up so I would be happy to see more reviews 🙏