Fix check links and make it simpler

[pipo02mix]

What this PR does / why we need it

It split the check link validation for doc section making it easier to track errors. Also it reduces the checks in changes/ section since we don't want to fix external URLs for old changelog entries

Things to check/remember before submitting

• If you made content changes

  • Run make dev to render and proofread content changes locally.
  • Bump last_review_date in the front matter header if you reviewed the entire page.

[marians]

It seems like this is not working as intended. I ran it in https://github.com/giantswarm/docs/actions/runs/8539886897/job/23395648737 and the first check starts on the /overview page, but recurses into all other pages. So we end up checking the entire site multiple times.

[pipo02mix]

Fixed. I will try to pass the tests too

[pipo02mix]

sadly it runs against the current online docs.giantswarm.io page so I cannot demonstrate the changes fix the linter :)

[pipo02mix]

@marians can you take a look?

[marians]

I just ran the workflow here: https://github.com/giantswarm/docs/actions/runs/8615042101/job/23609717739

The first step finds broken links and exits with non-zero exit code. As a result, the workflow does not continue after the step, so other links are not checked.

[pipo02mix]

yeah that is a problem, maybe I can cache all errors and only stop if the array is not empty, let me try

[pipo02mix]

now should be okish @marians PTAL

[marians]

Looks like we are getting there!

::set-output is deprecated and will be removed. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ for info on what to use instead.

[marians]

Not sure where I saw ::set-output. Probably looked at an outdated diff.