search

giantswarm / docs

The Giant Swarm documentation site
http://docs.giantswarm.io
Apache License 2.0
4 stars 8 forks source link

Add Backstage intro page #2238

Closed marians closed 2 months ago

marians commented 2 months ago

What this PR does / why we need it

https://github.com/giantswarm/giantswarm/issues/30563

Things to check/remember before submitting

marians commented 2 months ago

@pipo02mix Are we happy? ;-)

marians commented 2 months ago

Thanks @AndiDog for the detailed review.

Did we actually decide that we don't address customers directly anymore by "you"? I know that the vale linting did that, but can't remember we decided to adapt to it in that sense.

marians commented 2 months ago

Vale emits warnings, but no errors. Not sure why the check fails anyway.

I'd like to merge the content as it is now. Can you please approve @pipo02mix ?

AndiDog commented 2 months ago

Thanks @AndiDog for the detailed review.

Did we actually decide that we don't address customers directly anymore by "you"? I know that the vale linting did that, but can't remember we decided to adapt to it in that sense.

We didn't make this explicit. I'd love to have some guidelines, because very often the absolute terms "Giant Swarm" and "customer" (or maybe also "you" in a tutorial?) are better than some other combinations (especially "we" – who is "we"?). Could be nice to have in a documentation guide.