giantswarm / endpoint-operator

Apache License 2.0
2 stars 1 forks source link

Add CurrentState for endpoints #6

Closed MarcelMue closed 6 years ago

MarcelMue commented 7 years ago

My goal here is to split the endpoint similarly to our other operators and implement the CurrentState and some tests.

MarcelMue commented 6 years ago

I would appreciate some feedback if I am going in the right direction here. My thoughts were that the endpoint is reconciled but doesn't have any properties, so the desired state is always generated by querying the k8s api for annotations. Is this a decent direction or are there better ideas?

The current state is therefor always just a list of all endpoints.

xh3b4sd commented 6 years ago

Let me try to get this straight.

WDYT?

MarcelMue commented 6 years ago

This makes sense to me. I will try to implement it the way you described and hopefully everything will clear up from there. I hope to have some decent looking attempt tomorrow and then @calvix and I can look how the progress is going.

Thanks for your input ❤️

xh3b4sd commented 6 years ago

Ok cool. Maybe lets get the filtering in this PR done and go ahead with other steps in separate PRs.