giantswarm / happa

Web user interface for Giant Swarm – Beyond managed Kubernetes
https://www.giantswarm.io/
Apache License 2.0
21 stars 5 forks source link

Move CAPA userconfig values to global chart values #4561

Closed njuettner closed 11 months ago

njuettner commented 11 months ago

BREAKING CHANGE

New contract for CAPA clusters, see https://github.com/giantswarm/cluster-aws/tree/master/helm/cluster-aws#values-schema-documentation

Issue: https://github.com/giantswarm/roadmap/issues/2954

What does this PR do?

We moved helm values of cluster-aws into global chart values because we want to split Common Clusters CR's and Provider CR's in different repos. Therefore we need to move all shared values into global chart values for making them visible between multiple helm charts, e.g. cluster-aws <-> cluster.

More information on global chart values here.

The userconfig changes from:

apiVersion: v1
data:
  values: |
    connectivity:
      availabilityZoneUsageLimit: 3
      bastion:
        enabled: true
      network: {}
      topology: {}
    controlPlane: {}
    metadata:
      name: nick
      organization: giantswarm
    nodePools:
      nodepool0:
        instanceType: m5.xlarge
        maxSize: 10
        minSize: 3
        rootVolumeSizeGB: 300
    providerSpecific: {}
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    giantswarm.io/cluster: nick
  name: nick-userconfig
  namespace: org-giantswarm

to

apiVersion: v1
data:
  values: |
    global:
      connectivity:
        availabilityZoneUsageLimit: 3
        bastion:
          enabled: true
        network: {}
        topology: {}
      controlPlane: {}
      metadata:
        name: nick
        organization: giantswarm
      nodePools:
        nodepool0:
          instanceType: m5.xlarge
          maxSize: 10
          minSize: 3
          rootVolumeSizeGB: 300
      providerSpecific: {}
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    giantswarm.io/cluster: nick
  name: nick-userconfig
  namespace: org-giantswarm

Should this change be mentioned in the release notes?

njuettner commented 11 months ago

@gusevda we released 0.50.0 and already released kubectl-gs. Do you mind if we can merge it?

gusevda commented 11 months ago

Looks good to me.