search

giantswarm / happa

Web user interface for Giant Swarm – Beyond managed Kubernetes
https://www.giantswarm.io/
Apache License 2.0
21 stars 5 forks source link

Support unified cluster-aws app #4612

Closed nprokopic closed 5 months ago

nprokopic commented 5 months ago

What does this PR do?

Towards https://github.com/giantswarm/roadmap/issues/3447

With cluster-aws v0.76.0 and newer, default apps are deployed with cluster-aws and default-apps-aws app is not deployed anymore.

What is the effect of this change to users?

This PR updates rendering of CAPA templates, so that default-apps-aws is not rendered anymore when cluster-aws version is v0.76.0 and newer.

How does it look like?

(Please add screenshots or screen recordings demonstrating the change.)

Any background context you can provide?

https://github.com/giantswarm/roadmap/issues/3119

What is needed from the reviewers?

Do the docs need to be updated?

Should this change be mentioned in the release notes?

If yes, please apply one of the following labels: kind/feature, kind/change, kind/bug, kind/removal, kind/ux-enhancement, kind/security

mproffitt commented 5 months ago

I think overall this looks ok - there's nothing that jumps out code-wise as being risky.

When I run the branch locally and render a cluster manifest for either a v0.75.0 or 0.76.0-alpha.1` cluster app version I see that default apps is included, as seen in the following screenshot

image

Switching the cluster app version to 0.76.0 does not include the default apps

happa-capa-0 76 0

nprokopic commented 5 months ago

When I run the branch locally and render a cluster manifest for either a v0.75.0 or 0.76.0-alpha.1` cluster app version I see that default apps is included

For v0.75.0 default-apps-aws App should be included.

However default-apps-aws App should not be included for 0.76.0-alpha.1 (and newer). I have fixed this now.