search

giantswarm / inago

Inago orchestrates groups of units on fleet clusters
https://giantswarm.io/
Apache License 2.0
18 stars 2 forks source link

trim trailing slash from group #240

Closed xh3b4sd closed 8 years ago

xh3b4sd commented 8 years ago

fixes #210

See tests.

RFR @JosephSalisbury @Nesurion @zeisss

codecov-io commented 8 years ago

Current coverage is 59.31%

Merging #240 into master will increase coverage by +0.32% as of b4ee7c5

Powered by Codecov. Updated on successful CI builds.

Nesurion commented 8 years ago

LGTM

JosephSalisbury commented 8 years ago

My original idea was just to do this in the cli package - why do we want it in the controller?

xh3b4sd commented 8 years ago

Makes no sense to me in the CLI. Would be needed in every damn place. Anyway, the "fix" is only a PR away.

JosephSalisbury commented 8 years ago

Works for me for now either way.