giantswarm / kvm-operator-node-controller

Manages Kubernetes nodes based on kvm-operator (host cluster) state.
Apache License 2.0
1 stars 1 forks source link

Adds healthz endpoint #10

Closed r7vme closed 6 years ago

r7vme commented 6 years ago

Fixes: https://github.com/giantswarm/kvm-operator-node-controller/issues/5

Tested, now node-controller restarted if master dies.

1) count errors 2) healthz will response with http 500 error count is not 0

xh3b4sd commented 6 years ago

Since this is a rather ugly workaround I hope we can improve this later on. Is there some movement in your k8s-client issue? I would prefer getting the design right with the circuit breaker idea and create a new client to get new TCP connections on each reconciliation.

r7vme commented 6 years ago

there is a silence https://github.com/kubernetes/client-go/issues/342