giantswarm / roadmap

Giant Swarm Product Roadmap
https://github.com/orgs/giantswarm/projects/273
Apache License 2.0
3 stars 0 forks source link

Check if there are any v1alpha2 AWSCluster resources #1472

Closed anvddriesch closed 3 months ago

anvddriesch commented 2 years ago

In Happa we have implementation for AWS clusters with API version - infrastructure.giantswarm.io/v1alpha2. We need to check if there are actually any clusters with such version, and if no, we should clean up the code.

todo

kuosandys commented 1 year ago

Looks like it has also already been removed from apiextensions: https://github.com/giantswarm/apiextensions/pull/898

kuosandys commented 1 year ago

While there aren't any awsclusters with API version v1alpha2, some of the cluster resources still hold a reference to the old API version. Ideally they should be aligned, but as it is, this breaks how how we determine which provider resources to fetch in happa.

Installations where the referenced API version is mismatched with the actual resource's API version: akita anchovy anteater antelope argali bandicoot flamingo valkyrie viking visitor

I've reverted the changes with https://github.com/giantswarm/happa/pull/3877 in the meantime and updated the task list above.

marians commented 3 months ago

@gusevda Can we close this issue? I don't think we want to invest in code cleanups for happa, right?

gusevda commented 3 months ago

Agree, closing it.