search

giantswarm / roadmap

Giant Swarm Product Roadmap
https://github.com/orgs/giantswarm/projects/273
Apache License 2.0
3 stars 0 forks source link

App-build-suite Migration #1607

Open gianfranco-l opened 1 year ago

gianfranco-l commented 1 year ago

Problem:

We use many different approaches to building apps (helm charts), which makes it hard to provide the same quality checks to all the builds. Currently, we would like to ensure that every Helm chart sets correct app ownership labels. This is already provided by abs, but it's not the standard build tool.

  1. Suggested solution

    Honeybadger recommends moving to app-build-suite (ABS) using the doc below

    Why:

    • it can be run on local machines the same way as on CI/CD
    • it already includes a lot of chart validation/linting tools
    • it supports and promotes plain/valid Helm Charts (without custom templating)

  2. Plan

    • Honeybadger will iterate on the documents above based on the feedback from the first teams that will decide to migrate to ABS. When there will be enough momentum (= enough/most product teams that see the need and the opportunity to move to ABS), team will provide a planned effort to enforce this policy to all product teams.
    • If needed, Honeybadger will add missing functionality to abs
uvegla commented 1 year ago

Mentioned this on @giantswarm/sig-releng today.

uvegla commented 1 year ago

Happa migration to ABS: https://github.com/giantswarm/happa/pull/3861 + related change in architect-orb: https://github.com/giantswarm/architect-orb/pull/399

uvegla commented 1 year ago

Happa migration to ABS: https://github.com/giantswarm/happa/pull/3861 + related change in architect-orb: https://github.com/giantswarm/architect-orb/pull/399

We need to support having multiple charts in the same repository to some extent because the Happa use case makes sense / would be hard to migrate fe-docs to a separate repository because the contents are generated based on code / tests for Happa.

weatherhog commented 2 days ago

@uvegla as you have been working on this in 2022. Can you tell from your last comment what is missing to proceed?

uvegla commented 2 days ago

I think the multi chart support needs to be checked (and who knows what else, so needs some research + picking up context). That is potentially mostly for edge scenarios. Then a guide could be written on how to upgrade (potentially migrate some to get some experience) and then I would say teams need to migrate their apps. Or HB does it for everyone, which is a (lengthy?) migration process as usual.