Avoid running Dex in a fork

giantswarm / roadmap

Giant Swarm Product Roadmap

https://github.com/orgs/giantswarm/projects/273

Apache License 2.0

3 stars 0 forks source link

Avoid running Dex in a fork #630

Closed snizhana-dynnyk closed 6 months ago

snizhana-dynnyk commented 2 years ago

Description

We are running a fork of Dex atm because we rely on support for the prefixing of group names with automatic id. These changes were declined upstream because they plan to implement middleware and design is far from being something that contributors agreed on.

Changes proposed upstream - https://github.com/dexidp/dex/pull/2051 Alternative - https://github.com/giantswarm/giantswarm/issues/16933 Find a solution to avoid 'customer:' group name prefix

TODO

[ ] try to bring our contributions upstream

marians commented 2 years ago

The upstream issue this is related to is

https://github.com/dexidp/dex/issues/918

marians commented 2 years ago

I just checked on the status upstream. It seems as if connector middlewares (which were the reason our PR was "rejected" or put on ice) don't have progressed at all.

@puja108 You commented there almost a year ago. Would it make sense if you could try again? Or should someone else?

The aspects we could mention are

Our implementation is tested in production with several connectors.
Middlewares have not progressed. Once they are here, the implementation could off course be changed.

puja108 commented 2 years ago

I'd prefer if you or someone from Rainbow would continue the conversation, so you can steer it better in the right direction. I would then still be available to +1 and/or escalate (and can take that role better then).

marians commented 2 years ago

ACK, done

anvddriesch commented 2 years ago

Let's try again to contribute upstream now that all connectors work with prefixing.

jonaz commented 7 months ago

Did you manage to get this upstream?

anvddriesch commented 7 months ago

@jonaz unfortunately not. We were told that it might be part of https://github.com/dexidp/dex/issues/1635 but the issue is still open.

jonaz commented 7 months ago

i did remind them here: https://github.com/dexidp/dex/issues/918#issuecomment-2011680310

gawertm commented 6 months ago

no news upstream for 2 years, not sure if we are going to use dex in the future anyways, closing for now. will revisit when discussing future of Dex