giantswarm / semver-bump

Semantic Versioing Bumper
Other
27 stars 6 forks source link

Add missing newline at end of file #20

Open davegallant opened 4 years ago

davegallant commented 4 years ago

When applying bumps, a version file's final newline is stripped, which is an eye sore in a GitHub pull request. See below:

image

zeisss commented 4 years ago

IIRC this was mainly so it is easy to process further, e.g. on a command line: VERSION=$(cat VERSION) make release. Having a newline in there leads to weird behavior afaik.