search

giantswarm / twitter-hot-urls-example

Example Giant Swarm service, tracking URLs mentioned on Twitter and creating a ranked list
3 stars 3 forks source link

adding namespace and docs #11

Closed puja108 closed 7 years ago

puja108 commented 7 years ago

RFR @marians @webwurst

marians commented 7 years ago

Is the idea to add this to the docs as a guide?

I would remove THUX from the title and headline, since it's no longer self explanatory as an abbreviation. Maybe add a sentence somewhere early to explain that we call this example application "Twitter Hot URIs Example - short THUX".

marians commented 7 years ago

The docs content still explains the resolver-scaler, which isn't there any more I think.

marians commented 7 years ago

Also rebrow is still mentioned in the text.

marians commented 7 years ago

The component names in text and graphical overview differ in some parts.

puja108 commented 7 years ago

Yes, I'd like to have this in docs as an example, will work on your fixes

puja108 commented 7 years ago

Fixed according to @marians' comments. For rebrow I added that by default it is not deployed, I didn't remove it cause it's also in the overview.png

marians commented 7 years ago

BTW, I am available to change the overview image :)

webwurst commented 7 years ago

please remove DEVNOTES.md :)

webwurst commented 7 years ago

see there for current version to create manifests-all.yaml: https://github.com/giantswarm/kubernetes-prometheus/blob/e1830e749452d769cc804976033886e7ed89fbc3/development.md

at the end there is no --- anymore. still not sure if i need to add an additional \n.

puja108 commented 7 years ago

done

puja108 commented 7 years ago

aded some last minute fixes ;)

puja108 commented 7 years ago

btw, I saw that rebrow is still deployed