search

giawa / opengl4csharp

OpenGL 4 Bindings (partially based on OpenTK) for C#
Other
232 stars 61 forks source link

Throw exception when shader compiling or linking fails #16

Closed TheAIBot closed 5 years ago

TheAIBot commented 5 years ago

Uhh i somehow messed up so badly that i had to create a whole new pr. Sorry about that. Previous pr was #15.

So i did as you requested. pr is updated with thew newest changes from the dotnetcore branch. Code is now using ´´´ShaderLog´´´ and ´´´ProgramLog´´´. I moved some of the code into GlMethods.cs so the preallocated arrays could be used. Last i added a few comments and method descriptions.

Offtopic Hopefully it all works now. I have few other changes i can commit soon but before i do that i wanted to ask you if there is any unit tests for the dotnetcore branch? I made a Matrix2 class that seems to work correct but i am sure you would like it if such a pr came with tests.

giawa commented 5 years ago

Awesome, thanks for making those changes.

giawa commented 5 years ago

Regarding testing, there is an OpenGL Unit Tests project. You're welcome to put tests in there. They are not run automatically as part of CI, but you should run them manually before commit.