search

giawa / opengl4csharp

OpenGL 4 Bindings (partially based on OpenTK) for C#
Other
232 stars 61 forks source link

Matrix & VBO Changes #50

Closed ghost closed 4 years ago

ghost commented 4 years ago

Added this[int, int] to Matrix4. Added conversion methods to VBO.

I have found the changes useful in my own projects.

giawa commented 4 years ago

Thanks for submitting your PR! I left a few comments. I think it is worth splitting this PR into two - one which adds this[int row, int col] to Matrix4, and another (after further discussion) that could potentially add a type of VBO that will keep a copy of the data. In general, I do not think VBO should automatically keep a copy of the data, but it might be worth having a VBO type that does. I'm definitely open to suggestions here. Let me know what you think!

ghost commented 4 years ago

As I do not know how to use GitHub that well, I am just going to close this, and do other pull requests with your changes.