Closed ghost closed 4 years ago
I updated it with your proposed changes. I had to add this[int]
to Vector4, as it did not have one.
Since Vector uses the Get
method, perhaps it is worth modifying this code so that matrices also use Get
. What do you both think? Also, agreed on the comment from TheAIBot about putting the Exception
under the else case.
Since Vector uses the
Get
method, perhaps it is worth modifying this code so that matrices also useGet
. What do you both think? Also, agreed on the comment from TheAIBot about putting theException
under the else case.
Yeah, I will update the pull request with the changes.
Get
has been added to Vector2
as part of a recent PR. I suggest merging the dotnetcore branch back into your branch and then continuing from there. Thanks!
I made a mistake, and I have to redo this pull request.
I added
this[int column, int row]
to all the matrix classes. I found it useful in Matrix4, and I use it in my code.