giawa / opengl4csharp

OpenGL 4 Bindings (partially based on OpenTK) for C#
Other
232 stars 61 forks source link

Changes to Matrix2, Matrix3, Matrix4 #51

Closed ghost closed 4 years ago

ghost commented 4 years ago

I added this[int column, int row] to all the matrix classes. I found it useful in Matrix4, and I use it in my code.

ghost commented 4 years ago

I updated it with your proposed changes. I had to add this[int] to Vector4, as it did not have one.

giawa commented 4 years ago

Since Vector uses the Get method, perhaps it is worth modifying this code so that matrices also use Get. What do you both think? Also, agreed on the comment from TheAIBot about putting the Exception under the else case.

ghost commented 4 years ago

Since Vector uses the Get method, perhaps it is worth modifying this code so that matrices also use Get. What do you both think? Also, agreed on the comment from TheAIBot about putting the Exception under the else case.

Yeah, I will update the pull request with the changes.

giawa commented 4 years ago

Get has been added to Vector2 as part of a recent PR. I suggest merging the dotnetcore branch back into your branch and then continuing from there. Thanks!

ghost commented 4 years ago

I made a mistake, and I have to redo this pull request.