search

gibaBR / Switch-Backup-Manager

Complete Switch Backups management tool
373 stars 54 forks source link

[REQUEST] add NSZ compressed format support #152

Closed bartvincke closed 4 years ago

bartvincke commented 4 years ago

currently, v1.2.2 does not recognize the new compressed format, please add this format as well

garoxas commented 4 years ago

hey @gibaBR someone just reported that apparently NSZ format only compress program NCA which is not used by SBM, so a simple changes to allow .nsz extension will do as can be seen in the screenshot below

sbm

but please do mind there might be some issues I missed during testing I've tested with several files and looks like everything run normal, but we'll never know. the format itself is still in infancy so there could be some few changes later on that may break the compatibility. hell if someone decided to compress all NCA then it'll break the compatibility since I didn't (and won't) add support for NCZ

so what do you think about it? if you're okay with it, I'm ready with a PR

gibaBR commented 4 years ago

As always, you are the man!!

Do it! Thank you very much, one more time.

[]`s

Gilberto Júnior http://raspberrybrasil.blogspot.com.br/ http://www.flickr.com/photos/gibajr/

On Mon, Oct 21, 2019 at 12:35 PM Garoxas notifications@github.com wrote:

hey @gibaBR https://github.com/gibaBR someone just reported that apparently NSZ format only compress program NCA which is not used by SBM, so a simple changes to allow .nsz extension will do as can be seen in the screenshot below

[image: sbm] https://user-images.githubusercontent.com/11901820/67219523-67f33b00-f452-11e9-8817-58ef7d952e51.png

but please do mind there might be some issues I missed during testing I've tested with several files and looks like everything run normal, but we'll never know. the format itself is still in infancy so there could be some few changes later on that may break the compatibility. hell if someone decided to compress all NCA then it'll break the compatibility since I didn't (and won't) add support for NCZ

so what do you think about it? if you're okay with it, I'm ready with a PR

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gibaBR/Switch-Backup-Manager/issues/152?email_source=notifications&email_token=AFKGL2UW2HFTSURGZYIBC33QPXD45A5CNFSM4JBWJXC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB2YELY#issuecomment-544571951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFKGL2WOD3HZ344MGKCQTUTQPXD45ANCNFSM4JBWJXCQ .

garoxas commented 4 years ago

You're very much welcome man 😄