search

gibbed / SteamAchievementManager

A manager for game achievements in Steam.
zlib License
5.7k stars 696 forks source link

Sea of Thieves achievement not displaying #204

Open jsdratm opened 3 years ago

jsdratm commented 3 years ago

The achievement for Sea of Thieves entitled "#BeMorePirate" doesn't show up, perhaps something to do with the # symbol?

jsdratm commented 3 years ago

Looks like this code in Manager.cs is causing it to show up as achievement ID "19" as the label instead of the real name "#BeMorePirate". I'm not sure why this code is implemented this way, since it seems to show up fine in the list if you remove this block of code.

if (item.Text.StartsWith("#", StringComparison.InvariantCulture) == true) { item.Text = info.Id; } else { item.SubItems.Add(info.Description); }

gibbed commented 3 years ago

This is legacy code from around when I first made SAM, there was a game, one of Valve's, I think, that had localization string IDs instead of a real description.