search

gibber-cc / gibberish

Fast, JavaScript DSP library that creates JIT optimized audio callbacks using code generation techniques
387 stars 35 forks source link

Booleans were not handled when generating UGen code. #17

Closed abramhindle closed 7 years ago

abramhindle commented 7 years ago

We need gulp to make this build so I added that in the README.

abramhindle commented 7 years ago

Also I think you use a Mac or Windows because there was a case sensitivity build problem. Also big.js wasn't part of the dependencies.

Now I've got it built on ubuntu 16.04 just fine, but I had to get a node 6 deb package.

abramhindle commented 7 years ago

There was no Clamp. And Pow was wrong. Booleans were not handled so the Sampler example did not work. It would blow up when true was used for the loops attribute. There's a slight mess in that I pointed it my genish repo. I suggest that you pull this branch and build yourself since that messy dist stuff is included as well. Probably should not commit dist files :-/

charlieroberts commented 7 years ago

This branch still had the readme from the previous branches, which was pretty much obsolete. Most of the info is wrong. I'll try and update it (including your changes); obviously that's important if people are going to start using it!

I wonder if I should do some type of hack to convert booleans to ints automatically.... hmmm.

Anyways, let me work through these!

charlieroberts commented 7 years ago

Nice, as I just ran into bugs with the mono bus...