gibbonjoyeux / VCV-Biset

VCV Rack Biset modules library
GNU General Public License v3.0
37 stars 3 forks source link

A couple of thoughts on blank #22

Open baconpaul opened 5 months ago

baconpaul commented 5 months ago

Blank is cool

A couple of thoughts though

The cable 'plugs'

1: I sort of miss the hollow plug so I can see outputs lighting up. Any chance of that as an option? 2: Even if not, I think the lack of a plug 'corner' makes them look misaligned. Compare these two Screenshot 2024-01-28 at 9 04 35 AM Screenshot 2024-01-28 at 9 05 57 AM

The 'scope'

First and foremost what an amazingly useful feature. Thank you!

Screenshot 2024-01-28 at 9 06 55 AM Screenshot 2024-01-28 at 9 07 21 AM

Here's three thoughts about that display

  1. An overlay of a light gray line at 0v, +/-5v and +/- 10v would be very useful
  2. In the + 10v case you can see there's no 'padding'. Maybe a bit of margin around would be useful?
  3. You know the cable endpoints. You could add a small label to the bottom of the scope that said "Classic Output Left to VCF Input Left" so you know which hover cable you are showing
baconpaul commented 5 months ago

Oh I see now that gray line is there at the 0/5/10. So maybe I mean “a bit brighter with an axis in side on case it is obscured”

anyway cool idea - after working on bespoke I had the thought to do this too and it’s sort of on my “one day” list. And now I can take it off!! Awesome stuff

gibbonjoyeux commented 5 months ago

Highly inspired by bespoke indeed !

For the lights, I'd like to try to do that too but it probably won't look exactly the same. Perhaps not as realistic as the real "default" cables. By corners do you mean the small bumps at the beginning and end of cables ? I centered the cable endpoints with the plugs to avoid the misalignment you noticed :)

Thanks for the ideas ! I added padding and made the lines brighter for readability. I thought about having the plug name on the scope, it would be nice indeed. I probably won't do this for the next fix update but I think I'll add this to the one after !

Thanks again !

baconpaul commented 5 months ago

Yeah I meant the little sort of ellipse popping out.

Screenshot 2024-01-29 at 8 38 38 AM

I wonder if the surge ports aren't properly centered! I'll have to look. It's clearly mis-aligned in that image right? May be my fault :)

baconpaul commented 5 months ago

Screenshot 2024-01-29 at 9 02 08 AM Screenshot 2024-01-29 at 9 03 24 AM

Yeah OK the alignment is fine. Just the surge ports are darker on the bottom than the top so with the fill and no ellipse and hanging cable look 'more' misaligned. Here's a pair of screenshots well zoomed at cable tension 100% comparing. So no issue there. Sorry for the red herring!

Really then this amounts to "hollow centers with a glow", "maybe a cable nubbin" "label the scope" and "brighter lines" which would be nice to haves.

Cool stuff.

gibbonjoyeux commented 5 months ago

Thank you ! Handled some of your ideas, the others are in the todo list probably for the update after :)

baconpaul commented 5 months ago

Awesome!

gibbonjoyeux commented 4 months ago

I added leds to cables (with glow) as an option ! It should be available with the next Biset update :)