gibbonjoyeux / VCV-Biset

VCV Rack Biset modules library
GNU General Public License v3.0
37 stars 3 forks source link

Undoing Tracker deletion doesn't save patterns #24

Open flarn2006 opened 4 months ago

flarn2006 commented 4 months ago

I pressed Backspace on the tracker to delete something, but the whole Tracker module got deleted. I pressed Ctrl+Z and the Tracker module came back, but it just had the default song in it.

gibbonjoyeux commented 4 months ago

Hello ! I'm really sorry about that. Do you know which view your were using ? Timeline or Pattern ? Were you trying to delete a note line ?

I was just thinking about giving up the "complex" saving format I choose thinking that it would save speed and memory but appears to be less stable and time proof. I think that it will be one of the next updates for me before trying to add new features

Again, I'm really sorry about that

flarn2006 commented 4 months ago

Don't worry; I was just messing around and it wasn't anything that really meant anything to me to keep. I was in Pattern view, and I was trying to delete a pattern that was on the timeline. The fact that the Tracker module got deleted wasn't the main issue though; the issue was that the deletion didn't undo properly.

On Tue, Feb 6, 2024 at 8:40 AM gibbonjoyeux @.***> wrote:

Hello ! I'm really sorry about that. Do you know which view your were using ? Timeline or Pattern ? Were you trying to delete a note line ?

I was just thinking about giving up the "complex" saving format I choose thinking that it would save speed and memory but appears to be less stable and time proof. I think that it will be one of the next updates for me before trying to add new features

Again, I'm really sorry about that

— Reply to this email directly, view it on GitHub https://github.com/gibbonjoyeux/VCV-Biset/issues/24#issuecomment-1929024754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHZUONK2PYXAHB6QO6MBLYSHT7HAVCNFSM6AAAAABC22SWI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGAZDINZVGQ . You are receiving this because you authored the thread.Message ID: @.***>

gibbonjoyeux commented 4 months ago

I switched yesterday to the new saving method. It is indeed way more stable, particularly in this case. You can now copy / paste the tracker module between patches.

The fix will be sent with my next library update

flarn2006 commented 4 months ago

Like with the other issue, the new version (2.0.9) didn't fix it.