gibbonjoyeux / VCV-Biset

VCV Rack Biset modules library
GNU General Public License v3.0
42 stars 3 forks source link

Random crashes when loading/reloading patches with Tracker #25

Open flarn2006 opened 9 months ago

flarn2006 commented 9 months ago

This is an intermittent issue but I narrowed down a way to reproduce it:

  1. Add a Tracker module
  2. Save the patch
  3. Click "Play Song" on the module
  4. File→Revert
  5. If it didn't crash, repeat step 4 until it does.

So far I have only tested this on Linux.

gibbonjoyeux commented 9 months ago

Thank you for the report ! I didn't even know the Revert function to be honest and it's quite useful. I can indeed reproduce the crash, even on Windows.

It happens that the new saving method fixes this crash so it's a new argument for me to keep this method for stability. The fix will be sent on my next library update :) Thanks again !

flarn2006 commented 9 months ago

You're welcome; glad you could kill two birds with one stone!

flarn2006 commented 9 months ago

I just downloaded the new update and the issue still occurs.

gibbonjoyeux commented 9 months ago

Hello ! Yes, it's normal, I think this update (2.0.9) was already sent to VCV when I worked on fixing the issues you reported. This will be for the 2.0.10. I wanted to add some requested featured to the new update on top of the fix you mentioned but I think I have less time for this right now so I will try to send it this week or the one after and keep this new features for another update. Sorry about that !