Biset Blank causes Rack to crash upon quitting in x64 and ARM64 versions of Rack 2.4.1

[pgatt]

Hi there,

Paul Gatt from VCV Rack Technical Support here, we have had a user raise a report about Biset Blank crashing Rack x64 Mac version, I've reproduced on ARM64 version. Rack crashes upon quitting Rack if Biset Blank is in the patch. User was on Biset 2.0.8, I'm on Biset 2.0.9

Thread 9 Crashed:
0   libRack.dylib                          0x1017a30d0 rack::window::Window::getMods() + 16
1   plugin.dylib                           0x14aab1a00 Blank::process(rack::engine::Module::ProcessArgs const&) + 112
2   libRack.dylib                          0x10178d970 rack::engine::Module::doProcess(rack::engine::Module::ProcessArgs const&) + 168
3   libRack.dylib                          0x1017870e4 rack::engine::Engine::stepBlock(int) + 1312
4   libRack.dylib                          0x10178b920 rack::engine::Engine_fallbackRun(rack::engine::Engine*) + 316
5   libRack.dylib                          0x10178c2bc void* std::__1::__thread_proxy[abi:v15006]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void (*)(rack::engine::Engine*), rack::engine::Engine*>>(void*) + 44
6   libsystem_pthread.dylib                0x1a6d63fa8 _pthread_start + 148
7   libsystem_pthread.dylib                0x1a6d5eda0 thread_start + 8

[gibbonjoyeux]

Sorry for the trouble and thanks for the report !

Yes that's the second time I use APP->window in a process() without checking it's existence. It's fixed and will be on the next update (2.0.10) along some other fixes.

Do you have the email of the user ? I'd like to tell him / her that the issue can be temporarily avoided by disabling the Scope on MAJ option in the context menu.

Thanks again !

[pgatt]

I will let them know, thanks for the speedy response.